ci: Exclude build tooling (resources/) from coverage by dblythy · Pull Request #10561 · parse-community/parse-server

dblythy · 2026-07-05T13:33:43Z

Issue

resources/buildConfigDefinitions.js is a build-time codegen tool (run via npm run definitions), not shipped runtime code. It's currently measured for coverage at ~19% (158 uncovered lines), which drags the project coverage number down for something that isn't part of the product.

Approach

Exclude resources/** from nyc instrumentation. The bulk of the file is the codegen pipeline plus the file-read/write block guarded by if (require.main === module), which only runs on direct execution and can't be exercised by the test suite (the module only exports mapperFor). Excluding build tooling from coverage is standard practice and reflects the project number on product code only.

Tasks

Add tests

Summary by CodeRabbit

Chores
- Updated coverage configuration to exclude files in the resources directory from coverage results.

resources/buildConfigDefinitions.js is a build-time codegen tool, not shipped runtime code. Its generation pipeline only runs on direct execution (require.main === module), so it can't be exercised by the test suite, and it only exports mapperFor. Measuring it reports ~19% and drags the project coverage number down for code that isn't part of the product. Exclude resources/** from nyc instrumentation.

parse-github-assistant · 2026-07-05T13:33:46Z

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
Group code into logical blocks. Add a short comment before each block to explain its purpose.
We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

coderabbitai · 2026-07-05T13:33:53Z

📝 Walkthrough

Walkthrough

The .nycrc coverage configuration now excludes files matching resources/** in addition to files under spec directories.

Changes

Coverage configuration

Layer / File(s)	Summary
Add resources coverage exclusion `.nycrc`	The `exclude` list adds the `resources/` glob alongside the existing `/spec/**` exclusion.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: moumouls

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Ignore

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Engage In Review Feedback	❌ Error	The branch has a single coverage-only commit and no repo evidence of review-comment discussion or follow-up addressing feedback.	Engage the reviewer in the PR comments, then either apply a follow-up commit or get the reviewer to retract the feedback before resolving it.

✅ Passed checks (6 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses the required ci: prefix and clearly matches the coverage exclusion change.
Description check	✅ Passed	The description covers Issue, Approach, and Tasks, matching the template well enough despite missing the optional Pull Request boilerplate.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Security Check	✅ Passed	Only change is adding `resources/**` to `.nycrc` excludes; no runtime or security-sensitive code changed, so no vulnerability pattern is introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-07-05T13:41:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.55%. Comparing base (6f3e07c) to head (633fc28).
⚠️ Report is 1 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha   #10561      +/-   ##
==========================================
+ Coverage   92.69%   93.55%   +0.85%     
==========================================
  Files         193      192       -1     
  Lines       17027    16832     -195     
  Branches      248      248              
==========================================
- Hits        15784    15747      -37     
+ Misses       1222     1064     -158     
  Partials       21       21

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mtrezza · 2026-07-20T10:51:55Z

@dblythy Please let CR review first before requesting a human review, thanks.

dblythy · 2026-07-20T10:55:25Z

@coderabbitai review

coderabbitai · 2026-07-20T10:55:41Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

dblythy · 2026-07-20T23:50:53Z

Thanks @mtrezza 🤩

parseplatformorg · 2026-07-24T14:24:56Z

🎉 This change has been released in version 9.10.1-alpha.4

dblythy requested review from a team and Moumouls July 20, 2026 09:52

mtrezza removed the request for review from a team July 20, 2026 10:52

Merge branch 'alpha' into ci/exclude-resources-coverage

633fc28

mtrezza merged commit 5838c07 into parse-community:alpha Jul 20, 2026
20 of 22 checks passed

dblythy deleted the ci/exclude-resources-coverage branch July 20, 2026 23:50

parseplatformorg added the state:released-alpha Released as alpha version label Jul 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ci: Exclude build tooling (resources/) from coverage#10561

ci: Exclude build tooling (resources/) from coverage#10561
mtrezza merged 2 commits into
parse-community:alphafrom
dblythy:ci/exclude-resources-coverage

dblythy commented Jul 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

parse-github-assistant Bot commented Jul 5, 2026

Uh oh!

coderabbitai Bot commented Jul 5, 2026 •

edited

Loading

Walkthrough

Changes

Pre-merge checks failed

Uh oh!

codecov Bot commented Jul 5, 2026 •

edited

Loading

Uh oh!

mtrezza commented Jul 20, 2026

Uh oh!

dblythy commented Jul 20, 2026

Uh oh!

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

dblythy commented Jul 20, 2026

Uh oh!

parseplatformorg commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

dblythy commented Jul 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Approach

Tasks

Summary by CodeRabbit

Uh oh!

parse-github-assistant Bot commented Jul 5, 2026

Uh oh!

coderabbitai Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Pre-merge checks failed

❌ Failed checks (1 error)

Uh oh!

codecov Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mtrezza commented Jul 20, 2026

Uh oh!

dblythy commented Jul 20, 2026

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dblythy commented Jul 20, 2026

Uh oh!

parseplatformorg commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dblythy commented Jul 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 5, 2026 •

edited

Loading

codecov Bot commented Jul 5, 2026 •

edited

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading